Repository navigation
fix(@schematics/angular): reject ng-packagr builders in entry-point schematic - #34680
Merged
clydin merged 1 commit intoNov 11, 2026
Merged
Conversation
…chematic Validate that a library project is not configured with either `@angular/build:ng-packagr` or `@angular-devkit/build-angular:ng-packagr` instead of strictly requiring `@angular/build:library`. This prevents running the `entry-point` schematic on legacy `ng-packagr` projects while allowing custom library builders or workspaces without a `build` target.
There was a problem hiding this comment.
Code Review
This pull request updates the entry-point schematic to allow library projects that use custom builders or have no build target. Instead of strictly requiring the build target to use the BuildLibrary builder, it now checks all targets and only throws an exception if an unsupported ng-packagr builder is detected. Additionally, corresponding unit tests have been added to verify support for custom builders, missing build targets, and unsupported builders. There are no review comments to address.
clydin
approved these changes
Nov 11, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates that a library project is not configured to use
@angular/build:ng-packagror@angular-devkit/build-angular:ng-packagrin theentry-pointschematic instead of strictly requiring@angular/build:library, allowing custom library builders or workspaces without abuildtarget.